-
Notifications
You must be signed in to change notification settings - Fork 13.6k
cuda/vulkan : bicubic interpolation #17022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+148
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you, looks good for OpenCL. |
0cc4m
approved these changes
Nov 8, 2025
Collaborator
0cc4m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Vulkan code is fine.
slaren
approved these changes
Nov 8, 2025
CISC
reviewed
Nov 8, 2025
…tests * adapt OpenCL backend to not support the OP in that case so tests don't fail
Collaborator
Author
|
Fixed the whitespace issues. Also did a rebase, which should fix the test-thread-safety issue from last CI run. |
CISC
reviewed
Nov 9, 2025
CISC
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ggml
changes relating to the ggml tensor library for machine learning
Nvidia GPU
Issues specific to Nvidia GPUs
OpenCL
Issues specific to the OpenCL backend
testing
Everything test related
Vulkan
Issues specific to the Vulkan backend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend support for
GGML_OP_UPSCALEwithGGML_SCALE_MODE_BICUBICggml_backend_supports_opto return false for bicubicCombined PR so I can add backend-ops tests without having them fail for some backends.